Repository navigation
Use CMake features to find NumPy - #333
HunterBelanger wants to merge 4 commits into
Conversation
|
I know it has taken me a bit to figure out the exact linking needed for the tests, but now, the current test failures seem to be due to the test environment not having the Looking at this link, it appears that starting with Python 3.15, the |
I don't think so. Also do you want to open another PR with a very small change that I can merge, so that you don't need to wait for approval to run the CI in this one? |
|
Yes, that is a good idea. In any case, it was clear that |
The current CMake script that is used to find NumPy does not always work for me, and sometimes causes problems on the different systems I build on. Given we have recently updated the minimum CMake version and the minimum pybind11 version, these changes now use the standard CMake tools to find Python3 and NumPy, and makes the links with the standard CMake targets. I specifically use Python3 in the CMake as the indicated pybind11 version no longer supports Python 2.7.